Solution #729
Open
Solution #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polyakiv-Andrey
suggested changes
Oct 11, 2023
app/main.py
Outdated
| class Carnivore(Animal): | ||
|
|
||
| def bite(self, animal: Animal) -> None: | ||
| if isinstance(animal, Carnivore): |
There was a problem hiding this comment.
Rewrite your code without return
app/main.py
Outdated
| self.alive.append(self) | ||
|
|
||
| def __repr__(self) -> str: | ||
| return (f"" |
Dimosphen1
suggested changes
Oct 12, 2023
app/main.py
Outdated
| self.name = name | ||
| self.health = health | ||
| self.hidden = hidden | ||
| self.alive.append(self) |
There was a problem hiding this comment.
alive is not an instance attribute, it is a class attribute. Call it from Animal here.
app/main.py
Outdated
| class Carnivore(Animal): | ||
|
|
||
| def bite(self, animal: Animal) -> None: | ||
| if not isinstance(animal, Carnivore): |
There was a problem hiding this comment.
Make check that the instance is exactly Herbivore, your code may be corrupted in case there would be other animals added later.
…stance in bite() [class Carnivore]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.